Add in-context media asset editing - #2905

This PR adds in-context Media Library asset editing to the admin image picker, image fields, and rich-text images/galleries by reusing MediaDetailPanel inside a new useMediaAssetEditor hook, and adds keyboard reordering to gallery blocks. The approach is sound: it stays inside the existing Kumo/dialog and TanStack Query patterns, preserves per-use metadata (alt/caption/layout) when creating cropped copies, and carefully coordinates the picker↔asset-dialog transitions with refs/generations so focus and selection state round-trip correctly.

I read the diff, the full changed source files, the media URL utilities, and the RBAC/role types. I did not run tests/formatting. The main code-level concern is a state-synchronization regression in the rich-text image panel; otherwise the implementation is careful and well-tested. There is also one small a11y/RTL polish item in the dark-variant slot.

This re-review of the in-context media asset editing PR finds the approach still sound: the picker↔detail workspace handoff, per-use metadata preservation, and keyboard reordering all fit the existing Kumo/TanStack Query patterns. The prior state-synchronization regression in the rich-text image panel is addressed by keying the ImageDetailPanel reset effect on a stable nodeKey rather than on the attributes object identity, and the added ImageDetailPanel / GalleryDetailPanel tests cover node-switching and cropped-copy preservation.

I read the full diff, the changed source files, the media API/types, and the RBAC role constants. The code is careful and well-tested. The remaining issues are minor a11y/RTL polish items: a couple of decorative icons in newly-added or changed buttons are still missing aria-hidden="true", which leaves them exposed to screen readers alongside the buttons' text/aria-labels. The changeset is useful and the docs update matches the implemented behavior.

No blocking logic, security, or convention regressions were found.

Findings

• [suggestion] packages/admin/src/components/ImageFieldRenderer.tsx:376

  The dark-variant “Add dark mode variant” button renders the decorative Moon icon without hiding it from assistive technologies. Sibling icons in this file already use aria-hidden="true"; this one should too so screen readers don’t announce both the icon and the button’s visible label.

  						icon={<Moon aria-hidden="true" />}
  

• [suggestion] packages/admin/src/components/editor/GalleryDetailPanel.tsx:443

  The per-image Replace button in the gallery settings card renders the ImageSquare icon as visible content. Because the button already has a visible label, the icon is decorative and should be hidden from accessibility APIs to match the other icons in this panel.

  					icon={<ImageSquare aria-hidden="true" />}
  

• [suggestion] packages/admin/src/components/editor/GalleryDetailPanel.tsx:392

  The thumbnail’s remove button has an aria-label, but the decorative Trash icon inside it is still exposed to assistive technologies. Add aria-hidden="true" so only the button label is announced.

  				<Trash className="h-3 w-3" aria-hidden="true" />
  

I reviewed the full diff for this feature PR, which adds in-context media asset editing to admin image pickers, image fields, and rich-text image/gallery nodes. It also updates MediaPickerModal, MediaDetailPanel, useMediaAssetEditor, plus tests, e2e coverage, docs, and a changeset.

The prior review asked for three decorative icons to be marked aria-hidden, and those are fixed in ImageFieldRenderer. I did not find any logic bugs, regressions, or broken contracts; RBAC checks, state reset keyed on nodeKey, and the intentional cache-only useQuery in GalleryPreviewImage all look reasonable.

I have two minor non-blocking suggestions: a few new decorative icons inside labelled buttons (and the empty-state icons) are still exposed to assistive tech because they lack aria-hidden="true", and the changeset should be tightened to match the repo's style guidance (past tense, one or two sentences).

Findings

• [suggestion] packages/admin/src/components/editor/GalleryDetailPanel.tsx:261

  The Plus icon in the Add Images button is decorative because the button already has visible text. Decorative icons should be hidden from assistive technology to avoid redundant announcements.

  				icon={<Plus aria-hidden="true" />}
  

• [suggestion] packages/admin/src/components/MediaDetailPanel.tsx:1800

  The Trash icon in the destructive Delete button is decorative because the visible label Delete / Deleting... provides the accessible name. Add aria-hidden="true" so screen readers don't also announce the icon.

  					icon={<Trash aria-hidden="true" />}
  

• [suggestion] packages/admin/src/components/MediaDetailPanel.tsx:1811

  The ArrowsClockwise icon in the Replace image button is decorative because the button has the visible text Replace image. Hide it from assistive technology with aria-hidden="true".

  					icon={<ArrowsClockwise aria-hidden="true" />}
  

• [suggestion] packages/admin/src/components/ImageFieldRenderer.tsx:514

  The ImageBroken icon next to the Image not found message is decorative. It should be hidden from assistive technology to avoid announcing a generic icon name alongside the already-clear text.

  						<ImageBroken className="h-5 w-5" aria-hidden="true" />
  

• [suggestion] packages/admin/src/components/ImageFieldRenderer.tsx:539

  The ImageIcon icon inside the empty-state Select image button is decorative because the button already has the visible text Select image. Add aria-hidden="true" to keep the accessible name clean.

  					<ImageIcon className="h-8 w-8" aria-hidden="true" />
  

• [suggestion] .changeset/bright-otters-edit.md:5

  AGENTS.md asks for changeset entries to be concise (one or two sentences) and in past tense. This entry uses present tense ("Adds") and is three sentences. Consider condensing and converting to past tense, e.g.:

  Added in-context Media Library asset editing to admin image pickers, image fields, and rich-text images and galleries, letting editors update metadata and focal points, create cropped copies, replace original image data, and reorder gallery images by keyboard without leaving the content editor.
  

Great!